Url::ParseUserinfo: Actually verify Password - #10785
Merged
Merged
Conversation
In Url::ParseUserinfo, after extracting the password, ValidateToken is incorrectly called upon m_Username instead of m_Password. This commit fixes this and actually verifies the password. The bug was introduced with the surrounding code in 6571ffc. Luckily, this does not seem to have any security impact. However, as being a bug, this commit now fixes the behavior.
julianbrost
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Url::ParseUserinfo, after extracting the password, ValidateToken is incorrectly called upon m_Username instead of m_Password. This commit fixes this and actually verifies the password.
The bug was introduced with the surrounding code in 6571ffc.
Luckily, this does not seem to have any security impact. However, as being a bug, this commit now fixes the behavior.