Change MAX_FINE_TIME to a constant value and fix time conversion#3113
Merged
tmplummer merged 1 commit intoJul 10, 2026
Conversation
Collaborator
Author
|
pre-commit.ci autofix |
tmplummer
reviewed
Apr 30, 2026
maxineofficial
approved these changes
May 4, 2026
Contributor
|
@alastairtree I'm happy to merge once the tests are failing and you're ready. It looks like the L1B validation uses the code you updated to calculate the expected L1A timestamps from the input files... if that's annoying for you to update, let me know and I can fix the tests. |
…Center#2464) Fine clock ticks run 0..65535 then roll over, so each tick is 1/65536th of a second, not 1/65535th. Changing MAX_FINE_TIME to 65536 fixes the existing coarse/fine <-> seconds conversions without further changes, and to_j2000ns now goes through to_seconds() so it also benefits from the corrected sclk-aware met_to_ttj2000ns conversion. Also update MAG L1b validation timestamps for fine-time fix. Regenerated the expected 't' column in T009-T012 mago/magi CSVs by rerunning the exact test setup with the corrected TimeTuple conversion, so the expected times reflect the ~15us/tick fine-time correction rather than the old off-by-one values. No other columns changed.
alastairtree
force-pushed
the
fix/mag-time-off-by-one-#2464
branch
from
4480c14 to
dd63b4e
Compare
Collaborator
Author
|
I have addressed all the comments, fixed the test data and and rebased this so should be ready to merge I hope @maxinelasp |
tmplummer
approved these changes
Jul 10, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
Great. Thanks @alastairtree!
tmplummer
merged commit 2d7ee43
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2464 - go there for in depth discussion