Conversation
Adds the Link component matching Carbon React's API (href, disabled, inline, visited, size, target, renderIcon, as, onClick). Disabled links render without an href, with role="link" and aria-disabled, and swallow clicks, matching the accessible-disabled-link pattern used in React. Also fixes a pre-existing JSON syntax error in .parity-check-data.json (missing quote on the Search entry) that was blocking the parity tooling. Closes #463 Signed-off-by: Patrick Pircher <patrick.pircher@ibm.com>
Contributor
📖 Docs Preview🔗 Preview URL: https://ibm.github.io/carbon-components-ember/pr-previews/pr-666/ Built from commit 968ccdd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #463
Summary
Linkcomponent matching Carbon React's API:href,disabled,inline,visited,size(sm/md/lg),target(autorel="noopener"for_blank),renderIcon,as(element tag override), andonClick.href, withrole="link"/aria-disabled="true", and swallow clicks — matching the accessible-disabled-link pattern used in React.carbon-components-ember/src/components/index.ts.test-app/tests/components/link-test.gts.docs-app/public/docs/2-components/link.mdwith live examples..parity-check-data.json(missing quote on theSearchentry) that was blocking the parity-check tooling.Test plan
pnpm buildsucceedspnpm glintpasses with no errors