Wire the landing CTAs to the animal and foster routes - #249
Merged
Conversation
The hero and closing call-to-action buttons rendered but went nowhere. Point 우리 가족 찾기 and 우리 가족 만나러 가기 at the animal list, and 임시보호 알아보기 at the foster route, via navigate(). A guest following them is sent through the auth gate to login, as with any consumer route. Adds an e2e that follows the hero and closing CTAs to /animals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The landing page's call-to-action buttons rendered but had no navigation. This wires them:
/animals/foster/animalsUses the app's
navigate()pattern (as in NotFoundState / VolunteerPage). A guest who follows a CTA hits the auth gate and is sent to login, like any other consumer route; an authed visitor lands on the target page.The animal cards in the '지금 만날 수 있는 친구들' section are static fixtures with no ids, so they aren't individually linkable — left as-is.
Verify
typecheck, lint, and the production build pass. Adds a landing e2e that logs in and follows the hero + closing CTAs through to
/animals; the full flow passes locally.