Remove redundant music checks in frontend methods#3586
Merged
Geokureli merged 2 commits intoHaxeFlixel:devfrom Apr 12, 2026
Merged
Remove redundant music checks in frontend methods#3586Geokureli merged 2 commits intoHaxeFlixel:devfrom
Geokureli merged 2 commits intoHaxeFlixel:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3580
Introduced in #3558
Now that music is added to
FlxG.sound.list(an unintended change, but not a bad thing)FlxG.sound.onFocusLostcalls music.onFocusLost twice. the second would set _resumeOnFocus to false since it was already pausedI'm not sure why music was not added to the list, I'll check for any other unintended side effects of this change before merging. That may have been be a breaking change, as if anyone checked the if the list contains the music, it would have been false, but is now true, but that seems like an odd thing to do.
I don't think I can unit test this, but i'll look and seeAdded tests