feat: allow function for dateFormat prop#6281
Draft
pataar wants to merge 4 commits intoHacker0x01:mainfrom
Draft
feat: allow function for dateFormat prop#6281pataar wants to merge 4 commits intoHacker0x01:mainfrom
pataar wants to merge 4 commits intoHacker0x01:mainfrom
Conversation
Extends the `dateFormat` prop to accept `(date: Date) => string` in addition to the existing `string | string[]`. This enables users to use `Intl.DateTimeFormat` or any custom formatting logic for the input display. When `dateFormat` is a function, locale and timeZone are delegated to the function itself. Parsing typed input is skipped since there is no format string to parse against. The `formatMultipleDates` callback is fully compatible — its `formatDate` helper automatically uses the function-based format when provided.
Inherits the user's system locale instead of hardcoding en-US.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dateFormatprop to accept(date: Date) => stringin addition tostring | string[], enablingIntl.DateTimeFormator any custom formatting logicDateFormattype alias exported from the package for consumer useformatMultipleDates,safeDateRangeFormat, andsafeMultipleDatesFormatare all compatible with function-based formatsdateFormatis a function, parsing typed input is gracefully skipped (no format string to parse against)Intl.DateTimeFormatusageExample usage
Test plan
safeDateFormat,safeDateRangeFormat,safeMultipleDatesFormatwith function dateFormatformatMultipleDatescallback with function dateFormat