Skip to content

🐛 Fix #6252: Fix the toggle calendar utility to properly close the datepicker #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balajis-qb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Fix #6252: Fix the toggle calendar utility to properly close the datepicker #6253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/click_outside_wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ const useDetectClickOutside = (
if (
!(
ignoreClass &&
target instanceof HTMLElement &&
target.classList.contains(ignoreClass)
target instanceof Element &&
target.closest(`.${ignoreClass}`)
)
) {
onClickOutsideRef.current?.(event);
Expand Down
2 changes: 1 addition & 1 deletion src/test/click_outside_wrapper.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ describe("ClickOutsideWrapper", () => {
addEventListenerSpy.mockRestore();
});

it("does not treat non-HTMLElement targets as ignored elements", () => {
it("does not treat non-Element targets as ignored elements", () => {
const addEventListenerSpy = jest.spyOn(document, "addEventListener");
render(
<ClickOutsideWrapper
Expand Down
Loading