Fix notification task completion not updating local app state#2184
Open
Captain-Vikram wants to merge 1 commit intoHabitRPG:mainfrom
Open
Fix notification task completion not updating local app state#2184Captain-Vikram wants to merge 1 commit intoHabitRPG:mainfrom
Captain-Vikram wants to merge 1 commit intoHabitRPG:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When a user completes a task directly from a notification action, the BroadcastReceiver often finishes execution and the system kills the process before the asynchronous database updates can complete. This causes a sync issue where the task is marked done on the server (user gets XP/Drops), but remains unchecked in the local task list until a full refresh.
Solution:
This PR implements goAsync() in LocalNotificationActionReceiver. This keeps the BroadcastReceiver alive while the taskRepository.taskChecked coroutine is running, ensuring the local database update completes successfully before the receiver is destroyed.
Changes:
Wrapped the complete_task_action logic in LocalNotificationActionReceiver.kt with goAsync() and pendingResult.finish().