feat(SDK-1161): wire PrintChecks into PayrollOverview - #2588
Open
krisxcrash wants to merge 2 commits into
Open
Conversation
Fifth and final slice of the print-checks feature stack (see #2584). The actual cutover: mounts Payroll.PrintChecks (from #2587) as its own banner in PayrollOverview, following the same pattern already used for the embedded ConfirmWireDetails component. Removes the isPrintChecksOpen state and onPrintChecksOpen prop that a bare modal mount would have needed, since PrintChecks now owns its own trigger banner and Modal lifecycle. Stacked on kw/feat/print-checks-4-orchestrator; targets that branch, not main. Once this and the rest of the stack merge, this replaces #2572 entirely. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifth and final PR in the print-checks stack (see #2584 for the full split rationale, splitting up #2572). This is the actual cutover — mounts
Payroll.PrintChecks(from #2587) as its own banner inPayrollOverview, the same wayConfirmWireDetailsis already embedded there.PayrollOverview.tsxmounts<PrintChecks companyId={companyId} payrollId={payrollId} onEvent={onEvent} />alongside the existingwireInConfirmationRequestpattern.isPrintChecksOpen/onPrintChecksOpenplumbing a bare modal mount would have needed —PrintChecksnow owns its own trigger banner andModallifecycle, soPayrollOverviewjust renders it.PayrollOverview's@eventsJSDoc table to the newpayroll/printChecks/*event names.Base branch note: targets
kw/feat/print-checks-4-orchestrator, stacked on PR #2587. Once this whole stack merges, it fully replaces #2572, which I'll close.Stack
Testing
npm run test -- --run src/components/Payroll/PayrollOverview src/components/Payroll/PrintChecks— 61 tests passnpx tsc --noEmitandnpm run lint:checkclean🤖 Generated with Claude Code