test: add stories and tests for PolicyConfigurationFormPresentation#1509
Merged
krisxcrash merged 2 commits intomainfrom Apr 8, 2026
Merged
test: add stories and tests for PolicyConfigurationFormPresentation#1509krisxcrash merged 2 commits intomainfrom
krisxcrash merged 2 commits intomainfrom
Conversation
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
jeffredodd
approved these changes
Apr 8, 2026
Base automatically changed from
kw/feat/policy-configuration-form-presentation
to
main
April 8, 2026 22:33
Storybook stories covering all accrual method variants (hours worked, fixed, unlimited) plus an edit mode story with pre-populated values. Unit tests (20) covering rendering, conditional field visibility when switching between methods, reset date month/day toggle, form submission, cancel action, and keyboard accessibility.
krisxcrash
force-pushed
the
kw/feat/policy-configuration-form-tests
branch
from
77d98df to
50c322c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on: #1508
Test coverage
Test plan
npm run test -- --run ...PolicyConfigurationForm.test.tsx)