feat(SDK-561): wire up SelectHolidays functional component#1497
Merged
krisxcrash merged 1 commit intomainfrom Apr 8, 2026
Merged
feat(SDK-561): wire up SelectHolidays functional component#1497krisxcrash merged 1 commit intomainfrom
krisxcrash merged 1 commit intomainfrom
Conversation
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
krisxcrash
force-pushed
the
kw/feat/sdk-561-holiday-helpers
branch
from
95314ae to
d4ca8f7
Compare
krisxcrash
force-pushed
the
kw/feat/sdk-561-select-holidays
branch
from
20357c1 to
c95b3bc
Compare
5 tasks
jeffredodd
approved these changes
Apr 8, 2026
krisxcrash
force-pushed
the
kw/feat/sdk-561-select-holidays
branch
from
c95b3bc to
db82a87
Compare
Move SelectHolidays logic into HolidaySelectionForm and rename presentation/types/tests/stories to follow SDK naming conventions (HolidaySelectionForm* pattern, co-located under HolidaySelectionForm/).
krisxcrash
force-pushed
the
kw/feat/sdk-561-select-holidays
branch
from
db82a87 to
8ca2f3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectHolidaysfunctional logic intoHolidaySelectionForm.tsx, which now manages holiday selection state, calls the create holiday pay policy mutation, and emits flow events (TIME_OFF_HOLIDAY_SELECTION_DONE,CANCEL)SelectHolidays*toHolidaySelectionForm*following SDK naming conventions (matchingPolicyListpattern)HolidaySelectionForm/and delete theTimeOffManagement/SelectHolidays/directoryshared/holidayHelpers.tsimport to reference the newHolidaySelectionFormTypeslocationStacks on #1496.
Test plan
npm run test -- --run src/components/UNSTABLE_TimeOff/HolidaySelectionForm/(10 tests pass)npm run test -- --run src/components/UNSTABLE_TimeOff/shared/(26 tests pass)npm run buildpassesHolidaySelectionFormContextual→HolidaySelectionForm→HolidaySelectionFormPresentation