[1.20] Fix chunk IO errors occurring when C2ME is installed (and async feature worldgen is enabled)#4883
Open
carbonatek wants to merge 2 commits into
Open
[1.20] Fix chunk IO errors occurring when C2ME is installed (and async feature worldgen is enabled)#4883carbonatek wants to merge 2 commits into
carbonatek wants to merge 2 commits into
Conversation
Contributor
Author
|
Have tested this extensively on both 1.20 and 1.21 (with and without C2ME), and it has worked well. That's all I can provide at this point. Basically had two worlds generating for the last 2 days without any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is a "port" of #4877 to the 1.20.1 branch, since the same bug affects 1.20 as well.
Implementation Details
Modified the OreIndicatorPlacer interface to include the argument for WorldGenLevel as well, and changed createPlacer to use said argument instead of the one passed down.
AI Usage
Outcome
Fixes: #4799 on the 1.20.1 branch
How Was This Tested
This was tested against a copy of my private modpack's server by generating another big portion of the world again. Unlike before, the server's worldgen did not "crash" due to MC's getPersistedStatus() being null.
Additional Information
Because of what this touches, it is technically an API breaking change.
Potential Compatibility Issues
None found out; the pack it was tested in has 240 mods and there were no issues during world generation, or general gameplay. Of course, given the nature, it is possible that there is an edge case somewhere. Needs testing.