Skip to content

Add slayer tower - #725

Merged
GregHib merged 17 commits into
mainfrom
slayer-tower-copy
Jun 24, 2025
Merged

Add slayer tower#725
GregHib merged 17 commits into
mainfrom
slayer-tower-copy

Conversation

@GregHib

@GregHib GregHib commented Jun 24, 2025

Copy link
Copy Markdown
Owner

#503

@GregHib GregHib changed the title Slayer tower copy Add slayer tower Jun 24, 2025
@GregHib

GregHib commented Jun 24, 2025

Copy link
Copy Markdown
Owner Author

Copy of #712 without all of the merge chaos which was causing issues

@github-actions

github-actions Bot commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 45.45455% with 102 lines in your changes missing coverage. Please review.

Project coverage is 35.41%. Comparing base (b110a8b) to head (e7f7260).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ontent/area/morytania/slayer_tower/SlayerTower.kts 42.42% 16 Missing and 3 partials ⚠️
...ld/gregs/voidps/engine/map/collision/Collisions.kt 0.00% 14 Missing ⚠️
...tent/entity/player/command/debug/DebugCommands.kts 0.00% 14 Missing ⚠️
.../content/area/morytania/slayer_tower/Nechryael.kts 47.61% 6 Missing and 5 partials ⚠️
...n/content/area/morytania/slayer_tower/Gargoyle.kts 75.75% 2 Missing and 6 partials ⚠️
...ain/kotlin/content/entity/player/combat/Attack.kts 0.00% 6 Missing and 2 partials ⚠️
...s/voidps/engine/client/update/npc/NPCUpdateTask.kt 37.50% 2 Missing and 3 partials ⚠️
...lin/content/area/wilderness/abyss/AbyssalDemon.kts 66.66% 0 Missing and 4 partials ⚠️
...me/src/main/kotlin/content/entity/combat/Target.kt 50.00% 2 Missing and 2 partials ⚠️
...e/src/main/kotlin/content/entity/combat/hit/Hit.kt 0.00% 3 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
Files with missing lines Coverage Δ
...gs/voidps/engine/entity/character/move/Teleport.kt 70.58% <100.00%> (+1.83%) ⬆️
...d/gregs/voidps/engine/entity/character/npc/NPCs.kt 58.67% <100.00%> (ø)
...in/content/area/morytania/slayer_tower/Banshee.kts 83.33% <ø> (ø)
...e/src/main/kotlin/content/entity/combat/Combat.kts 67.05% <100.00%> (ø)
.../src/main/kotlin/content/entity/death/NPCDeath.kts 66.14% <100.00%> (+0.26%) ⬆️
...c/main/kotlin/content/skill/magic/spell/Spells.kts 42.85% <100.00%> (+9.52%) ⬆️
...gine/entity/character/player/skill/level/Levels.kt 91.52% <50.00%> (-1.58%) ⬇️
...tent/entity/player/command/admin/AdminCommands.kts 3.57% <0.00%> (-0.01%) ⬇️
...in/kotlin/content/entity/player/equip/Equipment.kt 39.74% <0.00%> (-0.52%) ⬇️
game/src/main/kotlin/content/entity/sound/Sound.kt 45.00% <50.00%> (-0.77%) ⬇️
... and 14 more

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #725      +/-   ##
============================================
+ Coverage     35.32%   35.41%   +0.09%     
- Complexity     5148     5172      +24     
============================================
  Files          1411     1416       +5     
  Lines         54464    54562      +98     
  Branches      10639    10678      +39     
============================================
+ Hits          19237    19323      +86     
+ Misses        31558    31545      -13     
- Partials       3669     3694      +25     
Components Coverage Δ
Content 31.67% <49.05%> (+0.11%) ⬆️
Engine 38.57% <23.07%> (+0.19%) ⬆️
Network 71.43% <50.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib
GregHib merged commit 3a85bf6 into main Jun 24, 2025
5 checks passed
@GregHib
GregHib deleted the slayer-tower-copy branch June 24, 2025 15:57
M1krofin pushed a commit to M1krofin/void that referenced this pull request Jun 24, 2025
* Fix spawns and tidy up definitions

* Tidy up monster config files

* Add all npcs spawns

* Add slayer tower

* Remove auto formatting step

---------
Co-authored-by: MrSlayerGod <31116755+mrslayergod@users.noreply.github.com>
Co-authored-by: RSDEANEO <deane1991@live.co.uk>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

(cherry picked from commit 3a85bf6)
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Jun 29, 2025
* Fix spawns and tidy up definitions

* Tidy up monster config files

* Add all npcs spawns

* Add slayer tower

* Remove auto formatting step

---------
Co-authored-by: MrSlayerGod <31116755+mrslayergod@users.noreply.github.com>
Co-authored-by: RSDEANEO <deane1991@live.co.uk>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants