Skip to content

Add Prow and job config for bazelbuild/rules_k8s repo#1214

Open
chizhg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
chizhg:add-bazelbuild
Open

Add Prow and job config for bazelbuild/rules_k8s repo#1214
chizhg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
chizhg:add-bazelbuild

Conversation

@chizhg
Copy link
Copy Markdown
Member

@chizhg chizhg commented Oct 19, 2021

@chizhg chizhg force-pushed the add-bazelbuild branch 2 times, most recently from 3859fed to 02d7b10 Compare October 19, 2021 04:29
@chizhg
Copy link
Copy Markdown
Member Author

chizhg commented Oct 19, 2021

/hold
For workload identity.

fejta
fejta approved these changes Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ought to continue having its own service account and/or cluster

@google-oss-robot
Copy link
Copy Markdown
Collaborator

google-oss-robot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Copy Markdown
Collaborator

google-oss-robot commented Oct 20, 2021

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link
Copy Markdown
Collaborator

google-oss-robot commented Oct 20, 2021

@chizhg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-prow-config-validate f438e61 link true /test pull-prow-config-validate
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@listx listx Awaiting requested review from listx

@michelle192837 michelle192837 Awaiting requested review from michelle192837

1 more reviewer

@fejta fejta fejta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fejta fejta

Labels

approved do-not-merge/hold size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chizhg @google-oss-robot @fejta