test(contact-center-insights): add delay to createAnalysis test to ensure conversation readiness#4322
Draft
angelcaamal wants to merge 3 commits into
Draft
test(contact-center-insights): add delay to createAnalysis test to ensure conversation readiness#4322angelcaamal wants to merge 3 commits into
angelcaamal wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a 10-second delay in the createAnalysis.test.js file to ensure conversations are ready before analysis. Feedback suggests replacing the raw setTimeout with the project's existing delay helper function to maintain consistency and leverage its built-in backoff logic.
| ); | ||
|
|
||
| console.info('Waiting for conversation to be ready for analysis...'); | ||
| await new Promise(resolve => setTimeout(resolve, 10000)); |
Contributor
There was a problem hiding this comment.
Instead of using a raw setTimeout, consider using the existing delay helper function defined at the top of this file. This ensures consistency with the rest of the test file and leverages the built-in exponential backoff logic if the test retries after a failure.
Suggested change
| await new Promise(resolve => setTimeout(resolve, 10000)); | |
| await delay(this.test, 10000); |
References
- Maintain established boilerplate patterns across samples within a repository, even if it means deviating from technically optimal solutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a race condition found in the createAnalysis test. Due to the asynchronous nature of the backend ingestion process, the conversation was occasionally not fully ready to be analyzed, resulting in internal errors.
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.