Skip to content

VertexAI Artifact resource#17635

Open
slevenick wants to merge 9 commits into
GoogleCloudPlatform:mainfrom
slevenick:vertex-artifact
Open

VertexAI Artifact resource#17635
slevenick wants to merge 9 commits into
GoogleCloudPlatform:mainfrom
slevenick:vertex-artifact

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_vertex_ai_artifact`

@modular-magician

modular-magician commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ff6d2c4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 324 insertions(+)
google-beta provider View Diff 5 files changed, 1433 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_artifact (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_artifact" "primary" {
  labels = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 91 4 2
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIArtifact_update
  • TestAccVertexAIArtifact_vertexAiArtifactBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIArtifact_update
✅ Log TestAccVertexAIArtifact_vertexAiArtifactBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for ff6d2c4!

@modular-magician

modular-magician commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bd6c387:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 330 insertions(+)
google-beta provider View Diff 5 files changed, 1439 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 92 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIArtifact_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIArtifact_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for bd6c387!

@slevenick slevenick requested review from a team and rileykarson and removed request for a team May 19, 2026 21:59
Comment thread mmv1/products/vertexai/Artifact.yaml Outdated
Comment thread mmv1/products/vertexai/Artifact.yaml Outdated
description: |-
The version of the schema in schema_name to use.
- name: state
type: String

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically I leave these as strings, but this one doesn't look like it will change in the future

Comment thread mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_artifact_test.go Outdated
@modular-magician

modular-magician commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b8fdf9e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 328 insertions(+)
google-beta provider View Diff 5 files changed, 1497 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 92 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIArtifact_vertexAiArtifactExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIArtifact_vertexAiArtifactExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for b8fdf9e!

@modular-magician

modular-magician commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cca9450:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 328 insertions(+)
google-beta provider View Diff 5 files changed, 1497 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 92 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIArtifact_vertexAiArtifactExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccVertexAIArtifact_vertexAiArtifactExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for cca9450!

@modular-magician

modular-magician commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c138de4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1495 insertions(+)
google-beta provider View Diff 5 files changed, 1495 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 247 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 92 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIArtifact_vertexAiArtifactExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccVertexAIArtifact_vertexAiArtifactExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for c138de4!

@modular-magician

modular-magician commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d953f3c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1489 insertions(+)
google-beta provider View Diff 5 files changed, 1489 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 243 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
97 93 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for d953f3c!

@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0f47db8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1372 insertions(+)
google-beta provider View Diff 4 files changed, 1372 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 243 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_artifact (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_artifact" "primary" {
  region = # value needed
  state  = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
96 92 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for 0f47db8!

@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6c26a44:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1368 insertions(+)
google-beta provider View Diff 4 files changed, 1368 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 243 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_artifact (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_artifact" "primary" {
  region = # value needed
  state  = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
96 92 4 0
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick VCR tests complete for 6c26a44!

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

@slevenick, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@slevenick slevenick requested a review from shuyama1 June 2, 2026 16:42
@modular-magician

modular-magician commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6d6bcd4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1370 insertions(+)
google-beta provider View Diff 4 files changed, 1370 insertions(+)
terraform-google-conversion View Diff 1 file changed, 209 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 247 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_artifact

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
96 91 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIArtifact_vertexAiArtifactExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIArtifact_vertexAiArtifactExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick, @shuyama1 VCR tests complete for 6d6bcd4!

Comment on lines +94 to +95
immutable: true
output: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need immutable for output field

Comment on lines +11 to +14
schema_title = "system.Dataset"
schema_version = "0.0.1"
uri = "https://example.com/dataset"
state = "PENDING"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these fields required? If not, could we test the creation without specifying these. Just wanted to check if the API will return values for them if they're unset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants