feat: add alias ipv6 support for compute instances apis#17620
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f060671: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance_from_machine_image" "primary" {
network_interface {
alias_ipv6_range {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
network_interface {
alias_ipv6_range {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_instance_template" "primary" {
network_interface {
alias_ipv6_range {
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_region_instance_template" "primary" {
network_interface {
alias_ipv6_range {
subnetwork_range_name = # value needed
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @Gvantsats, @NickElliot VCR tests complete for f060671! |
NickElliot
left a comment
There was a problem hiding this comment.
can you please add the fields to the docs pages such as magic-modules/mmv1/third_party/terraform/website/docs/r/compute_instance.html.markdown? It needs to be in all the ones flagged in the above comment, thanks!
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 196c82d: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance_from_machine_image" "primary" {
network_interface {
alias_ipv6_range {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
network_interface {
alias_ipv6_range {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_instance_template" "primary" {
network_interface {
alias_ipv6_range {
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_region_instance_template" "primary" {
network_interface {
alias_ipv6_range {
subnetwork_range_name = # value needed
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @Gvantsats, @NickElliot VCR tests complete for 196c82d! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit aa6559c: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance_from_machine_image" "primary" {
network_interface {
alias_ipv6_range {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
network_interface {
alias_ipv6_range {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_instance_template" "primary" {
network_interface {
alias_ipv6_range {
subnetwork_range_name = # value needed
}
}
}
Resource: resource "google_compute_region_instance_template" "primary" {
network_interface {
alias_ipv6_range {
subnetwork_range_name = # value needed
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @Gvantsats, @NickElliot VCR tests complete for aa6559c! |
8756fa1
Resolve CheckForCommonAliasIp conflict with alias ipv6 support (GoogleCloudPlatform#17620): keep this PR's map-based CheckForCommonAliasIp and add the new beta-only CheckForCommonAliasIpv6; move checkForCommonAliasIpRanges inside the beta guard, since only the ipv6 path still uses the typed helper.
Add alias ipv6 support for compute apis instance and instance templates
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.