Skip to content

feat: add alias ipv6 support for compute instances apis#17620

Merged
NickElliot merged 3 commits into
GoogleCloudPlatform:mainfrom
Gvantsats:compute_alias_ipv6_support
May 21, 2026
Merged

feat: add alias ipv6 support for compute instances apis#17620
NickElliot merged 3 commits into
GoogleCloudPlatform:mainfrom
Gvantsats:compute_alias_ipv6_support

Conversation

@Gvantsats

@Gvantsats Gvantsats commented May 19, 2026

Copy link
Copy Markdown
Contributor

Add alias ipv6 support for compute apis instance and instance templates

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `alias_ipv6` field to `google_compute_instance` and `google_compute_instance_template` (beta)

@Gvantsats Gvantsats marked this pull request as ready for review May 19, 2026 07:28
@github-actions github-actions Bot requested a review from NickElliot May 19, 2026 07:28
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f060671:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 23 insertions(+), 17 deletions(-)
google-beta provider View Diff 12 files changed, 539 insertions(+), 5 deletions(-)
terraform-google-conversion View Diff 2 files changed, 43 insertions(+), 15 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    alias_ipv6_range {
      ip_cidr_range         = # value needed
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    alias_ipv6_range {
      ip_cidr_range         = # value needed
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_instance_template (310 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  network_interface {
    alias_ipv6_range {
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_region_instance_template (84 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    alias_ipv6_range {
      subnetwork_range_name = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_compute_instance
    • Expected Document Path: /website/docs/r/compute_instance.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]
  • google_compute_instance_from_machine_image
    • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]
  • google_compute_instance_from_template
    • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]
  • google_compute_instance_template
    • Expected Document Path: /website/docs/r/compute_instance_template.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]
  • google_compute_region_instance_template
    • Expected Document Path: /website/docs/r/compute_region_instance_template.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]

Test report

Analytics

Total Tests Passed Skipped Affected
1451 1353 93 5
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeInstanceTemplate_aliasIpv6Range
  • TestAccComputeInstance_addAliasIpv6Range
  • TestAccComputeInstance_removeAliasIpv6Range
  • TestAccComputeRegionInstanceTemplate_aliasIpv6Range

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstanceTemplate_aliasIpv6Range
✅ Log TestAccComputeInstance_addAliasIpv6Range
✅ Log TestAccComputeInstance_removeAliasIpv6Range
✅ Log TestAccComputeRegionInstanceTemplate_aliasIpv6Range
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Gvantsats, @NickElliot VCR tests complete for f060671!

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the fields to the docs pages such as magic-modules/mmv1/third_party/terraform/website/docs/r/compute_instance.html.markdown? It needs to be in all the ones flagged in the above comment, thanks!

@github-actions github-actions Bot requested a review from NickElliot May 21, 2026 08:27
@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 196c82d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 35 insertions(+), 17 deletions(-)
google-beta provider View Diff 15 files changed, 551 insertions(+), 5 deletions(-)
terraform-google-conversion View Diff 2 files changed, 43 insertions(+), 15 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    alias_ipv6_range {
      ip_cidr_range         = # value needed
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    alias_ipv6_range {
      ip_cidr_range         = # value needed
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_instance_template (310 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  network_interface {
    alias_ipv6_range {
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_region_instance_template (84 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    alias_ipv6_range {
      subnetwork_range_name = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_compute_instance_from_machine_image
    • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]
  • google_compute_instance_from_template
    • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]

Test report

Analytics

Total Tests Passed Skipped Affected
1456 1362 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRegionInstanceTemplate_aliasIpv6Range

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRegionInstanceTemplate_aliasIpv6Range

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@Gvantsats, @NickElliot VCR tests complete for 196c82d!

@modular-magician

modular-magician commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit aa6559c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 36 insertions(+), 17 deletions(-)
google-beta provider View Diff 16 files changed, 552 insertions(+), 5 deletions(-)
terraform-google-conversion View Diff 2 files changed, 43 insertions(+), 15 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    alias_ipv6_range {
      ip_cidr_range         = # value needed
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    alias_ipv6_range {
      ip_cidr_range         = # value needed
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_instance_template (310 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  network_interface {
    alias_ipv6_range {
      subnetwork_range_name = # value needed
    }
  }
}

Resource: google_compute_region_instance_template (84 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    alias_ipv6_range {
      subnetwork_range_name = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_compute_instance_from_machine_image
    • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
    • Fields: [network_interface.alias_ipv6_range network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]
  • google_compute_instance_from_template
    • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
    • Fields: [network_interface.alias_ipv6_range.ip_cidr_range network_interface.alias_ipv6_range.subnetwork_range_name]

Test report

Analytics

Total Tests Passed Skipped Affected
1456 1363 93 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@Gvantsats, @NickElliot VCR tests complete for aa6559c!

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NickElliot NickElliot added this pull request to the merge queue May 21, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 8756fa1 May 21, 2026
26 checks passed
GitOleksandrBokov added a commit to GitOleksandrBokov/magic-modules that referenced this pull request May 26, 2026
Resolve CheckForCommonAliasIp conflict with alias ipv6 support (GoogleCloudPlatform#17620): keep this PR's map-based CheckForCommonAliasIp and add the new beta-only CheckForCommonAliasIpv6; move checkForCommonAliasIpRanges inside the beta guard, since only the ipv6 path still uses the typed helper.
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants