fix: a11y actionable items fixes#3628
Merged
Merged
Conversation
Contributor
SDK Size
|
szuperaz
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR should fix some outstanding
a11yissues for screen readers. The prior foundation work (a11ycontext,useA11yLabel,useAccessibilityAnnouncer,useResolvedModalAccessibilityProps, translation namespace, etc.) shipped the primitives. This PR uses those primitives to fix the surfaces flagged by an audit - polls, message context menus, and bottom sheets.🛠 Implementation details
Five focused changes, each scoped to one surface:
Poll - actionable rotor (
Poll.tsx, newusePollAccessibilityActions/usePollAccessibilityLabel/PollUIStateContext)PollUIStateContextcarries state across the poll's modals (vote / see results / end vote confirm) so the available action set stays correct as the user navigates (we do this so that we have one source of truth for firing these actions)Poll & Message - context menu hint
accessibilityHint='a11y/Double tap and hold to activate contextual menu'on bothMessageContentandPoll, so screen reader users know a long-press menu is available before triggering itMessage overlay - open announcement (
MessageOverlayHostLayer.tsx)announceForAccessibility('Swipe right to go through different actions')when the overlay activates.useRefdedupes so it speaks once per open and resets on closeBottomSheetModal - modal trait + accessible dismiss (
BottomSheetModal.tsx)accessibilityRole='button'VoiceOverdouble tap goes intoonAccessibilityTapwhich goes intoonCloseTalkBackdouble tap goes intoaccessibilityActions=[{name:'activate'}]+onAccessibilityActionwhich then goes intoonCloseas wellonAccessibilityEscape={onClose}. Android hardware back was already wired throughModal.onRequestClose.800mssoVoiceOver's auto focus shift speech ("Close, button") doesn't preempt the announce mid sentence.Translations
a11y/*keys (Bottom sheet opened…, Close, Double tap and hold to activate contextual menu, Swipe right to go through different actions, plus the poll action labels) added to all 13 locales.🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch