fix(sync): skip install-only visual components in sync runtime#1276
fix(sync): skip install-only visual components in sync runtime#1276aparragithub wants to merge 1 commit into
Conversation
The installer persists claude-theme and opencode-gentle-logo in state.json, so sync builds a componentSyncStep for them, but the sync switch never handled them: they fell into the default branch and aborted the whole pipeline with 'component "claude-theme" is not supported in sync runtime' for every full-gentleman install. Skip them as no-ops — they are install-only and have nothing to re-apply on sync. Fixes Gentleman-Programming#1275
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe sync dispatcher now skips ChangesInstall-only component sync handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you, @aparragithub. Your report, diagnosis, and implementation in this PR identified the missing sync runtime coverage. We merged #1321 with the broader managed-refresh behavior instead of a no-op. The delivery commit preserves you as its Git author so your contribution remains visible in the repository history and contributor graph. Closing this PR as superseded by #1321. |
Closes #1275
PR Type
type:bug)Summary
gentle-ai syncaborted withcomponent "claude-theme" is not supported in sync runtimefor every full-gentleman install: the installer persistsclaude-themeandopencode-gentle-logoinstate.json, sync builds acomponentSyncStepper persisted component, and the switch never handled them, so they hit the default error branch and killed the whole pipeline.Changes
internal/cli/sync.goComponentClaudeThemeandComponentOpenCodeGentleLogobefore the default error branchinternal/cli/sync_test.goTestComponentSyncStepSkipsInstallOnlyComponents:Run()returns nil and reports no changed files for both componentsTest Plan
component "claude-theme" is not supported in sync runtime), green after the fixgo test ./internal/cli/passesgentle-ai syncon a machine with the full-gentleman selection persisted — pipeline completed across all 5 configured agents (previously aborted)review-d3944a9b347bff3b, risk medium,review-reliabilitylens, 0 findings, receipt approved; pre-commit/pre-push/pre-pr gates allowContributor Checklist
status:approvedfrom a maintainer)type:*label (needs maintainer to applytype:bug— no triage permission)Co-Authored-BytrailersSummary by CodeRabbit