Figure.directional_rose/Figure.magnetic_rose: Set the default position to the top right#4702
Merged
Conversation
…n to the top right
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit 8e9e93e |
yvonnefroehlich
left a comment
Member
There was a problem hiding this comment.
I agree the default position should be consistent across GMT and PyGMT.
Member
|
Seems like we have to do similar changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of proposed changes
For GMT<=6.6.0, the position argument is required when plotting directional or magnetic roses. When implementing
Figure.directional_roseandFigure.magnetic_rosein PyGMT, we decided to set the default position to the "bottom left" corner.In a recent PR GenericMappingTools/gmt#9074, the default position was changed to "Top Right." As a result, the default positions will be inconsistent between GMT and PyGMT.
Fortunately,
Figure.directional_roseandFigure.magnetic_rosewere added recently and have not yet been released. This gives us the opportunity to change the default behavior without breaking backward compatibility.This PR updates the default position.