shell: Add corner-radius to blur effects#32
Closed
ektorthebigbro wants to merge 1 commit intoGNOME:mainfrom
Closed
shell: Add corner-radius to blur effects#32ektorthebigbro wants to merge 1 commit intoGNOME:mainfrom
ektorthebigbro wants to merge 1 commit intoGNOME:mainfrom
Conversation
Add a new corner-radius property to ShellBlurEffect and apply a rounded mask in the final compositing pass. This allows blur surfaces to match the rounded geometry of the actor they are attached to instead of always rendering square blur edges.
Contributor
|
Thank you for contributing to gnome-shell! gnome-shell uses GitLab for code review. As such we have forwarded https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/9164 GNOME's GitLab instance also supports GitHub as one of the possible https://gitlab.gnome.org/users/sign_in If you are interested in sticking around within the GNOME community we https://www.gnome.org/get-involved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds a
corner-radiusproperty toShell.BlurEffectand applies a rounded mask during the final compositing pass.The effect can already blur actor and background content, but the blurred output is always composited as a rectangle. With this change, callers can keep the blur aligned with rounded surfaces instead of getting visible square blur corners.
Why
Rounded shell surfaces are common in themes and shell customizations, but the blur pipeline currently has no way to match that geometry. As a result, blurred surfaces can show square edges that extend beyond the rounded actor shape.
Exposing a corner radius on the blur effect keeps the blur output consistent with the surface it belongs to.
Validation
I was able to verify:
maingit diff --checkpassesI was not able to run a full local build in this environment because this machine currently has GNOME 49-era platform packages installed, while
mainnow targets GNOME Shell 50 and requires a newergjs(>= 1.87.1).