Skip to content

feat: well_manager + well estimator#3972

Open
tjb-ltk wants to merge 134 commits into
developfrom
feature/byer3/wm_we
Open

feat: well_manager + well estimator#3972
tjb-ltk wants to merge 134 commits into
developfrom
feature/byer3/wm_we

Conversation

@tjb-ltk

@tjb-ltk tjb-ltk commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replaces PR #3735 and extends PR #3971

Overview

This PR introduces

  1. An improved well schema layout and code refactor better suited for well modeling. The previous implementation primarily targeted Jacobian generation requirements for the coupled reservoir and well system.

  2. The well estimator is used to select the active well constraint by solving the well system assuming fixed reservoir conditions and selecting the constraint with the highest or lowest well flowing pressure.

    • the estimator is applied at beginning of Jacobian assembly of the coupled system
    • frequency determined via input setting
    • estimator is a data member of WellControl and a tailed version of PhysicsSolver for wells
    • logic underpins future capability to replace the segmented well model with other formulations

This is a breaking change, detailed migration instructions and migration script are posted at #4081

tjb-ltk and others added 30 commits September 29, 2025 16:50
@tjb-ltk
1) new constraint schema, 2) resturcture well jac assem loops
f9db9fd
@tjb-ltk
fix merge errors
a9cd276
@tjb-ltk
fix integrate errors
c59b1a6
@tjb-ltk
rel mode fix
48aabd4
@tjb-ltk
1) remove old code, 2) test different constraint org, 3) singlephase …
a85ee1d 
…broken
@tjb-ltk
1) SinglePhaseWell adopts new constraint convention, 2) Change constr…
8366922 
…aint class hierachy , 3) Remove all old constraint handling methods/variables, 4) it compiles ...
@tjb-ltk
fix constraint sign and normalizers
4f49bf1
@tjb-ltk
1) compositional_multiphase_wells_1d.xml matches geos branch, 2) sing…
2e82b49 
…lephase still needs testing
@tjb-ltk
compressible_single_phase_wells_1d.xml matches geos branch
6281018
@tjb-ltk
improve naming conventions for well constriant files and classes
205889f
@tjb-ltk
fix reference to 'internal' is ambiguous error
b6ae5ef
@tjb-ltk
1) well constraint schema script, 2) converted xmls, 3) Failed conver…
fa61ab1 
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
@tjb-ltk
schema
292c90f
@tjb-ltk
1)fixes for catalogue registration, 2) xml convert script still needs…
d4eb504 
… to fixed and inputFiles regenerated
@tjb-ltk
fix liq rate schema
bd3d0cf
@tjb-ltk
Revert "1) well constraint schema script, 2) converted xmls, 3) Faile…
723c2bc 
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml"

This reverts commit fa61ab1.
@tjb-ltk
xml with new constraint schema, try 2
e39ccf1
@tjb-ltk
merge devel
d0fcf79
@tjb-ltk
remove extra ;
8b21d69
@tjb-ltk
remove :
470a7ff
@tjb-ltk
fix constraint schema, phase name on totalvol constraint not allowed
b8a90f4
@tjb-ltk
update well constraint schema
94fc9ad
@tjb-ltk
1) expose method for unit tests, 2) update unittests accordingly
17047bd
@tjb-ltk
schema change
c6a349f
@tjb-ltk
1) remove unused vars , add missing constriant type in selector
1c03220
@tjb-ltk
reintroduce control keyword option to be consistent with previous in …
b5f6c5d 
…well initialization vagaries assoiated with useSurfaceConditions=0
@tjb-ltk
updated schema
c43657e
@tjb-ltk
add back control keyword
e78ef18
@tjb-ltk
add control schema to unit tests
b000ed4
@tjb-ltk
uncrustify should be automated
a319e0e
@tjb-ltk tjb-ltk added flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels May 8, 2026
@dkachuma dkachuma requested a review from Copilot May 14, 2026 19:48
Copilot AI reviewed May 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@tjb-ltk tjb-ltk added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review labels Jun 4, 2026
@tjb-ltk tjb-ltk requested a review from joshua-white as a code owner June 11, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner
@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner
@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner
@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner
@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner
@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner
@herve-gross herve-gross Awaiting requested review from herve-gross herve-gross is a code owner
@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner
@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner
@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner
@victorapm victorapm Awaiting requested review from victorapm victorapm is a code owner
@jafranc jafranc Awaiting requested review from jafranc jafranc is a code owner
@bd713 bd713 Awaiting requested review from bd713 bd713 is a code owner
@joshua-white joshua-white Awaiting requested review from joshua-white joshua-white is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tjb-ltk tjb-ltk

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjb-ltk @dkachuma