Skip to content

[OPTIMIZATION] Reuse sequences in the stages - #394

Open
NotHyper-474 wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
NotHyper-474:chore/reusing-sequences
Open

[OPTIMIZATION] Reuse sequences in the stages#394
NotHyper-474 wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
NotHyper-474:chore/reusing-sequences

Conversation

@NotHyper-474

@NotHyper-474 NotHyper-474 commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

Associated Funkin PR

FunkinCrew/Funkin#7217

Description

Note

This PR requires the associated PR, but not the other way around. The current code will still run like before if the associated PR got merged without this one.

Implements the functionality introduced by the associated PR to the sequences used by the scripts. This has no functional change (except for maybe better memory usage? As in, removing the need to create a new sequence every time.)

Screenshots/Videos

N/A

@github-actions github-actions Bot added size: medium A medium pull request with 100 or fewer changes. pr: hscript PR modifies game scripts. status: pending triage Awaiting review. and removed size: medium A medium pull request with 100 or fewer changes. labels Mar 23, 2026
@Hundrec
Hundrec self-requested a review March 23, 2026 09:42
@Hundrec Hundrec changed the title [CHORE] Reuse sequences in the stages [OPTIMIZATION] Reuse sequences in the stages Mar 23, 2026
@Hundrec Hundrec added type: optimization Involves a performance issue or a bug which causes lag. topic: associated Has an associated pull request in the Funkin repository. labels Mar 23, 2026
@NotHyper-474
NotHyper-474 force-pushed the chore/reusing-sequences branch 3 times, most recently from 1fa5345 to 0dba3dc Compare March 23, 2026 20:23
@NotHyper-474
NotHyper-474 force-pushed the chore/reusing-sequences branch from 0dba3dc to 98f52d6 Compare April 10, 2026 18:01
@NotHyper-474
NotHyper-474 force-pushed the chore/reusing-sequences branch from 98f52d6 to 1b5e22e Compare May 24, 2026 18:22
@NotHyper-474
NotHyper-474 force-pushed the chore/reusing-sequences branch from 1b5e22e to 43cac6c Compare August 12, 2026 00:41
@github-actions github-actions Bot added size: tiny A tiny pull request with 4 or fewer changes. size: medium A medium pull request with 100 or fewer changes. pr: github PR modifies GitHub metadata files. pr: documentation PR modifies documentation or README files. and removed size: medium A medium pull request with 100 or fewer changes. pr: hscript PR modifies game scripts. size: tiny A tiny pull request with 4 or fewer changes. labels Aug 12, 2026
@NotHyper-474
NotHyper-474 changed the base branch from develop to preview/public-playtest August 12, 2026 00:41
@NotHyper-474 NotHyper-474 added pr: hscript PR modifies game scripts. and removed pr: github PR modifies GitHub metadata files. pr: documentation PR modifies documentation or README files. labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: hscript PR modifies game scripts. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: associated Has an associated pull request in the Funkin repository. type: optimization Involves a performance issue or a bug which causes lag.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants