Proposal: Return the OuterHtml of the page for getResponseContentLogMessage#38
Open
ronaldtebrake wants to merge 1 commit into
Open
Proposal: Return the OuterHtml of the page for getResponseContentLogMessage#38ronaldtebrake wants to merge 1 commit into
getResponseContentLogMessage#38ronaldtebrake wants to merge 1 commit into
Conversation
When using getContent we're basically omitting the `<html>` tag from the actual page. There are scenario's where there is useful information added to that tag. Using getOuterHtml will actually ensure the entire content is rendered.
Contributor
|
@ronaldtebrake I think additional information is good) Therefore, please fix the tests and we can make a release |
|
This could potentially be a breaking change. Can we not make it available
in a new option/param?
|
Contributor
|
@andrewnicols Thanks for noticing - third-party libraries can suffer if they are tied to a certain format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thanks for all the hard work going on to this!
I've got a proposal, I'm not sure if it's favorable or if there is anything missing.
When using
$session->getPage()->getContent()we're basically omitting the<html>tag from the actual log message.There are scenario's where there is useful information added to that tag. Using getOuterHtml will actually ensure it is rendered.
With
getContentin place:with
getOuterHtmlin place