-
Notifications
You must be signed in to change notification settings - Fork 6
feat(service-providers): default to reachable nodes and add endorsed provider badge #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rjan90
merged 8 commits into
FilOzone:main
from
beck-8:feat/service-providers-reachable-endorsed
Apr 27, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
abd992e
feat(service-providers): add default reachable filter for node access…
beck-8 447868c
feat(service-providers): mark approved providers with endorsed badge
beck-8 653dcc5
Potential fix for pull request finding
beck-8 7c6b46f
fix(filters): tighten reachable typing and fix ProviderOverview usage
beck-8 ed92f89
refactor(provider-overview): require isApproved prop explicitly
beck-8 8712123
feat(providers): split endorsed status from approved and update legend
beck-8 cc831ad
chore(ci): align biome schema and format legend
beck-8 5b24336
Merge remote-tracking branch 'origin/main' into feat/service-provider…
rjan90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { Fieldset } from '@headlessui/react' | ||
|
|
||
| import { CheckboxesContainer } from '@/components/CheckboxesContainer' | ||
| import { CheckboxWithLabel } from '@/components/CheckboxWithLabel' | ||
| import { FilterHeading } from '@/components/FilterHeading' | ||
|
|
||
| import { useFilterQueryState } from '../hooks/use-filter-query-state' | ||
|
|
||
| const REACHABLE_FILTER_OPTIONS = [ | ||
| { value: 'true', label: 'Accessible' }, | ||
| { value: 'false', label: 'Unavailable' }, | ||
| ] as const | ||
|
|
||
| export function ReachableFilter() { | ||
| const { filterQueries, toggleFilterQuery } = useFilterQueryState() | ||
|
|
||
| return ( | ||
| <Fieldset> | ||
| <FilterHeading>Node Accessibility</FilterHeading> | ||
| <CheckboxesContainer> | ||
| {REACHABLE_FILTER_OPTIONS.map((option) => ( | ||
| <CheckboxWithLabel | ||
| key={option.value} | ||
| checked={filterQueries.reachable.includes(option.value)} | ||
| onChange={() => toggleFilterQuery('reachable', option.value)} | ||
| label={option.label} | ||
| /> | ||
| ))} | ||
| </CheckboxesContainer> | ||
| </Fieldset> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
src/app/service-providers/utils/parse-reachable-filter-value.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { createParser } from 'nuqs' | ||
|
|
||
| import type { ReachableFilterValue } from '../hooks/use-filter-query-state' | ||
|
|
||
| export const parseAsReachableFilterValue = createParser({ | ||
| parse: (value) => { | ||
| if (value === 'true' || value === 'false') { | ||
| return value as ReachableFilterValue | ||
| } | ||
| return null | ||
| }, | ||
| serialize: (value) => value, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reachable filter is attached to the
softwareVersioncolumn, which means this column now carries two concerns (displaying version + filtering reachability). If another filter is ever applied to this column, they'd conflict. Worth considering a dedicated virtual/computed column for reachability to keep things clean and make the relationship explicit.