Merge dev into main#92
Merged
Merged
Conversation
…#84) The security shield badge previously only appeared when the validator approved at least one [security]-tagged comment. That conflated 'security review found issues' with 'security review ran', and meant clean PRs gave no positive signal that the security pass had executed. Move the badge prepending out of the validator prompt and into the post-execution update-comment-link step so it is added deterministically whenever automatic_security_review=true. The badge now means 'security review was performed', regardless of whether any findings exist. - updateCommentBody accepts securityReviewRan and prepends the shield badge (with a guard against double-prepending if an earlier step already added it) - update-comment-link.ts reads AUTOMATIC_SECURITY_REVIEW from env - action.yml passes inputs.automatic_security_review through to the post-step - review-validator-prompt no longer instructs the LLM to prepend the badge (removes a discretionary, findings-gated path) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
The shallow depth preset pointed at "kimi-k2-0711", which is a stale
identifier the public Droid CLI no longer recognizes (verified on a
GitLab pipeline: `Invalid model: kimi-k2-0711`). The deep preset
("gpt-5.2") works fine; only shallow was broken. Anyone passing
review_depth=shallow today would silently hit this error.
Per `droid exec --model <invalid>` the current valid Kimi K2 model
IDs are `kimi-k2.6` (newest) and `kimi-k2.5`. Switch the preset to
`kimi-k2.6` which preserves the original design intent: a fast,
cheap Kimi K2 model for quick shallow reviews. Explicit `review_model`
override still wins via `resolveReviewConfig`.
Updated:
- src/utils/review-depth.ts: SHALLOW_DEFAULTS.model
- action.yml + review/action.yml: input descriptions
- README.md: presets table + reference in review_model docs
All 377 tests pass.
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
Droid finished @factory-nizar's task —— View job |
factory-nizar
added a commit
that referenced
this pull request
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.