Skip to content

AMD GPU Support via HIP/ROCm - #1379

Draft
ptheywood wants to merge 79 commits into
masterfrom
amdgpu
Draft

AMD GPU Support via HIP/ROCm#1379
ptheywood wants to merge 79 commits into
masterfrom
amdgpu

Conversation

@ptheywood

@ptheywood ptheywood commented Apr 13, 2026

Copy link
Copy Markdown
Member

Adds AMD GPU support via HIP / ROCm

Caution

This is still a WIP - do not review, merge or expect CI to be happy

It will be rebased many times, and may become the base branch for other AMD/HIP/ROCm/clang related PRs so they can all be merged into master in a single go.

Decisions to make during review

  • FLAMEGPU_GPU=CUDA/HIP/OFF - Best I've come up with, but not super keen on this cmake option name.
    • support lower case values as well (i.e. make it upper case before validation)?
    • BACKEND, VENDOR (prolyl not), PLATFORM, API
  • FLAMEGPU_CURAND_ENGINE - deprecate and rename? Its a bit grim to do with it being a cache var not an option.
  • Ensure consistency in use of new macros? i.e. defined(FLAMEGPU_USE_CUDA) vs ifdef FLAMEGPU_USE_CUDA. Maybe do HIP first and fallback to the CUDA version so intellisense doesn't get offended?
  • Update Docs repo accordingly
  • TODO: DO NOT MERGE in test suite, where wrapper function changes happened but I didn't update the test suite.
  • Still don't understand why the wrapper helper is needed for agent functions but not for agent function conditions....
  • Fully udpated changelog from this PR (more breaking changes / deprecations not yet included)
  • Telemetry NVCCVersion. Or maybe use a diff field name anyway?

As of 2026-06-10 tests pass with:

  • CUDA 13.2 on linux
  • HIP 7.0 on linux
  • CUDA 12.4 on windows

@ptheywood
ptheywood force-pushed the amdgpu branch 2 times, most recently from 6487086 to 6779e5e Compare June 5, 2026 16:51
@ptheywood ptheywood mentioned this pull request Jun 8, 2026
7 tasks
@ptheywood
ptheywood force-pushed the amdgpu branch 2 times, most recently from d8282b4 to 382fbeb Compare June 9, 2026 14:57
@ptheywood ptheywood mentioned this pull request Jul 28, 2026
…re no longer required due to cleaner abstraction
- Deprecates rather than removes FLAMEGPU_CURAND_ENGINE
- Case insensitive values (as before) while validating earlier
- Fixes the default value in the readme, which was missed in #873
FLAMEGPU_GPU is still implemented, but deprecated, to not break external repositories which already reference this
…r.cu

This was required after a rebase including a new test added as part of 1401. This include must be implicit on msvc and gcc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AMD ROCTx support AMD + GLM Initial AMD GPU Support (ROCm/HIP)

1 participant