Update SQLite to 399cada13519f6d8b6b445b625857a9a655f (JSONB_EACH support) - #2290
Merged
Conversation
Contributor
Author
|
cc @flodnv |
Contributor
Author
|
Added you @tylerkaraszewski in case you are aware of any reason we shouldn't update SQLite. |
flodnv
approved these changes
Oct 2, 2025
pecanoro
approved these changes
Oct 2, 2025
iwiznia
approved these changes
Oct 2, 2025
danieldoglas
approved these changes
Oct 2, 2025
tylerkaraszewski
approved these changes
Oct 2, 2025
This was referenced Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This checkin has support for JSONB_EACH which should have performance benefits over JSON_EACH
From Richard:
I'm planning to use
JSONB_EACHfor queries accessing arrays inside policies.From my testing with queries on traversing large
customUnits, the query is 3-4x times fasterSQLite version used: https://sqlite.org/src/info/399cada13519f6d8
Compiled files with:
followed SO: https://stackoverflowteams.com/c/expensify/questions/154
Fixed Issues
I want to use this in these optimizations we are working here https://github.com/Expensify/Auth/pull/17395#issuecomment-3357971320 and in other queries that use JSON_EACH
Tests
I ran Auth tests using this branch, and they passed
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes