fix(CellsValues): guard against missing / unexpected telemetry values#256
Merged
fix(CellsValues): guard against missing / unexpected telemetry values#256
Conversation
pfeerick
force-pushed
the
3djc/harden-cellsvalue
branch
from
3df6ce9 to
658e27b
Compare
pfeerick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of #255 based on Philmoz last changes (#254). Did notice some weird errors when cells count is changed, battery inserted and values not fully present create hard to reproduce issues. This guards about a few identified situations, that might (or not) present themselves