Skip to content

Check equality of expressions up to convertibility#996

Open
oskgo wants to merge 1 commit into
mainfrom
fix-990
Open

Check equality of expressions up to convertibility#996
oskgo wants to merge 1 commit into
mainfrom
fix-990

Conversation

@oskgo
Copy link
Copy Markdown
Contributor

@oskgo oskgo commented May 7, 2026

This was already being done when checking equality of instructions and statements, but not expressions.

It seems like this was an accident. The EqTest module exposes the for_expr definition used by the internal EqTest_base while defining its own that ends up being used by for_instr and for_stmt. The relevant line number is 1896.

It's likely that this will break something, but I don't have an example. I found this while trying to fix #990, but AFAICT this change won't break any uses of sim by itself. See also #997.

@oskgo
Copy link
Copy Markdown
Contributor Author

oskgo commented May 29, 2026

On further investigation, this is unlikely to be breaking. It makes byupto stronger, but since byupto always closes goals that won't be breaking.

I haven't looked into whether other code uses EqTest.for_expr, but an earlier iteration of this PR broke EqTest.for_expr but only ended up failing CI tests for byupto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sim less robust

1 participant