chore: bump webpack-cli to v5 - #6700
Conversation
📝 WalkthroughWalkthroughBootstrapライブラリをv5.3.3からv5.3.8に更新し、著作権年を2011–2024から2011–2025に変更。複数のCSSファイルでセレクタ特異性の調整、CSSカスタムプロパティを使用した新しいテーマング機構の導入、フレックスボックス計算の最適化を実施。webpack-cliを4.9.2から5.1.4にアップグレード。 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
html/template/admin/assets/css/bootstrap.css (1)
1436-1468:⚠️ Potential issue | 🟠 Major生成済み Bootstrap CSS が現行の stylelint ルールと衝突しています。
Line 1436 / Line 1456 / Line 1468 の
:-moz-placeholder系セレクタ、Line 4381 以降のRGBA(...)、Line 5722 以降の宣言前空行で、現行ルールに違反しています。Bootstrap の生成物をそのまま管理する運用なら、このファイルを lint 対象から外すか、生成元/ビルド側でリポジトリのルールに合わせないと、同種の更新のたびに止まります。Also applies to: 4381-4449, 5722-5754
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@html/template/admin/assets/css/bootstrap.css` around lines 1436 - 1468, The generated Bootstrap CSS is violating stylelint via deprecated/incorrect pseudo-element syntax (e.g. selectors like .form-floating > .form-control:not(:-moz-placeholder) and related rules), uppercase RGBA(...) uses, and stray blank lines before declarations; either remove this generated file from stylelint/CI lint targets, or change the generator/output to be lint-compliant by: replacing single-colon pseudo-elements with standard double-colon forms (use ::placeholder and vendor ::-moz-placeholder where appropriate) for selectors referenced (e.g. .form-floating > .form-control:not(:-moz-placeholder), .form-floating > .form-control:-webkit-autofill ~ label), normalize function names to lowercase (rgba(...)) for occurrences around the RGBA block, and eliminate empty lines before declarations (the blocks flagged around lines 5722+); update the generator or pre-commit step so future builds produce the corrected selectors and formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@html/template/admin/assets/css/bootstrap.css`:
- Around line 1436-1468: The generated Bootstrap CSS is violating stylelint via
deprecated/incorrect pseudo-element syntax (e.g. selectors like .form-floating >
.form-control:not(:-moz-placeholder) and related rules), uppercase RGBA(...)
uses, and stray blank lines before declarations; either remove this generated
file from stylelint/CI lint targets, or change the generator/output to be
lint-compliant by: replacing single-colon pseudo-elements with standard
double-colon forms (use ::placeholder and vendor ::-moz-placeholder where
appropriate) for selectors referenced (e.g. .form-floating >
.form-control:not(:-moz-placeholder), .form-floating >
.form-control:-webkit-autofill ~ label), normalize function names to lowercase
(rgba(...)) for occurrences around the RGBA block, and eliminate empty lines
before declarations (the blocks flagged around lines 5722+); update the
generator or pre-commit step so future builds produce the corrected selectors
and formatting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b51528d9-ea18-473e-8ab9-6517a2fa1e35
⛔ Files ignored due to path filters (8)
html/bundle/admin.bundle.js.mapis excluded by!**/*.maphtml/bundle/front.bundle.js.mapis excluded by!**/*.maphtml/bundle/install.bundle.js.mapis excluded by!**/*.maphtml/template/admin/assets/css/bootstrap.css.mapis excluded by!**/*.maphtml/template/admin/assets/css/bootstrap.min.css.mapis excluded by!**/*.maphtml/template/default/assets/css/style.css.mapis excluded by!**/*.maphtml/template/default/assets/css/style.min.css.mapis excluded by!**/*.mappackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (11)
html/bundle/admin.bundle.jshtml/bundle/admin.bundle.js.LICENSE.txthtml/bundle/front.bundle.jshtml/bundle/front.bundle.js.LICENSE.txthtml/bundle/install.bundle.jshtml/bundle/install.bundle.js.LICENSE.txthtml/template/admin/assets/css/bootstrap.csshtml/template/admin/assets/css/bootstrap.min.csshtml/template/default/assets/css/style.csshtml/template/default/assets/css/style.min.csspackage.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6700 +/- ##
============================================
- Coverage 78.65% 78.62% -0.03%
Complexity 6824 6824
============================================
Files 476 476
Lines 27078 27078
============================================
- Hits 21299 21291 -8
- Misses 5779 5787 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR EC-CUBE#6735 (2026-04-22) 以降に 4.3 へ merge された 12 ファイルの変更を取り込む. - EC-CUBE#6752 Dockerbuild 修正 (index.php) - EC-CUBE#6705 product_class post size 修正 (twig) - EC-CUBE#6700 webpack-cli ^5.1.4 / chart.js ^4.5.1 等 (package.json) - 追加テスト, i18n, codeception router fix Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
概要(Overview・Refs Issue)
DependabotのPRがコンフリクトが多発していたため、別PRとしてあげます。
#6213
方針(Policy)
実装に関する補足(Appendix)
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目
Summary by CodeRabbit
リリースノート
Chores
Style