Remove control characters from PMC properties - #194
Merged
Conversation
Incredible-O
requested review from
0sewa0,
VLazarevic,
avorima,
gkrenn,
jdanieck,
jokuniew and
s-quatres
July 23, 2026 11:49
0sewa0
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under certain circumstances, tenant settings values accept newlines, which are passed to the bootstrapper config, then written to
ruxitagentproc.conf.This is problematic because control characters like newlines could let property values inject additional INI sections.
Relevant ticket: ICP-6290.
How can this be tested?
Unit tests