Open
Conversation
added 6 commits
October 30, 2012 15:49
Not only this fixes a bug, as portbuilder should work with the information retrieved by pkg info and a new repository might mess it up, but this also consists in a noticeable speed boost for updates with many RepoInstall stages.
Currently. pkgng downloads packages to the All/ subdirectory (which actually depends on how `pkg repo` is run). It's quite safe to assume that this is the right directory at the moment, but this is going to change in pkgng's future (to something smarter). This commit references DragonSA#21.
pkg_* tools share PKG_CACHEDIR with pkgng (/var/cache/pkg/All, at the moment). This commit references DragonSA#21.
...and change pkg.add() to use the downloaded package. This fixes pkgng downgrading packages using `pkg install`. RepoFetch is considered complete when the package file already exists. This is good for pkg_* tools, but not for pkgng, as `pkg fetch` is able to understand if the package is corrupted, and eventually download a new file. This commit references DragonSA#21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to parallelise package fetching and to workaround
pkg installdowngrading behaviour.Package cache directory
mkdir()is missing for the implementation to be safe.