fix: add unzip to arch server set up#4176
Open
daniel-abramov wants to merge 1 commit intoDokploy:canaryfrom
Open
fix: add unzip to arch server set up#4176daniel-abramov wants to merge 1 commit intoDokploy:canaryfrom
daniel-abramov wants to merge 1 commit intoDokploy:canaryfrom
Conversation
dosubot
bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
unzipinstallation whenarchis used as a target. This has been fixed in #1051 for Debian/Ubuntu targets.Greptile Summary
This PR adds
unzipto thepacmaninstall command for Arch Linux ininstallUtilities(), matching the fix already applied to Debian/Ubuntu targets in #1051. The change is correct and brings Arch in line with all other supported distros (alpine, ubuntu/debian, centos/fedora) that already installunzip.Confidence Score: 5/5
Safe to merge — minimal, targeted fix with no risk.
The change is a single-line addition of a missing package to an OS install list. It is consistent with the existing pattern across all other distros and matches the intent of the previously merged #1051. The only finding is a P2 observation about SLES/openSUSE also missing
unzip, which is out of scope for this PR and does not block merge.No files require special attention.
Vulnerabilities
No security concerns identified.
Comments Outside Diff (1)
packages/server/src/setup/server-setup.ts, line 495-496 (link)unzipalso missing for SLES/openSUSEThe same gap this PR fixes for Arch exists in the SLES/openSUSE branch —
unzipis absent while every other distro (alpine, ubuntu/debian, centos/fedora, arch after this fix) installs it.Reviews (1): Last reviewed commit: "fix: add unzip to arch server set up" | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!