feat: allow selecting stored registries for Docker image pull#3678
feat: allow selecting stored registries for Docker image pull#3678AceRRR10 wants to merge 3 commits intoDokploy:canaryfrom
Conversation
|
Hey! Thanks for the PR — the idea of allowing users to select a stored registry from the dropdown is great and makes a lot of sense to avoid redundant credential entry. 👍 However, we'd like to keep both options available in the UI simultaneously:
Right now, the PR hides the manual fields when a registry is selected, which is fine, but it also replaces the registry URL field with just the dropdown. We'd like both to coexist so the user has the flexibility to either:
Essentially, the dropdown should be an additional option, not a replacement. Something like: if the user selects a registry from the dropdown, the manual fields are hidden (as you have it). But if they select "None" (or a "Manual" option), the original fields (registry URL, username, password) should still appear exactly as they do today. Could you adjust the UI so both flows are available? Thanks! |
Add a registry dropdown to the Docker provider form, allowing users to select a previously saved registry instead of manually entering credentials. When a stored registry is selected, its credentials are used for docker login and the registry URL/username are prepended to the image name for pulling. Inline credential fields are hidden when a registry is selected, preserving backward compatibility.
Reverts the automatic prefixing of registry URL/username to the docker image name, aligning with the existing behavior where users provide the full image reference (e.g. ghcr.io/user/image:latest) in the Docker Image field. The stored registry is still used for docker login credentials only, consistent with how inline credentials worked before.
5cba249 to
772719a
Compare
|
Thanks for the review. Actually, the PR already supported both flows, when "None" was selected in the dropdown, the manual fields (Registry URL, Username, Password) were shown, exactly as they work today. Selecting a stored registry hides them. I've just pushed a small update to make this clearer: renamed "None" to "Manual" and grouped the dropdown options under a "Stored Registries" label so the intent is more obvious at a glance. |
What is this PR about?
When using the "Docker" source type for an application, users currently must manually enter
username,password, andregistryUrlfor every application. However, Dokploy already has a registry management system (Settings > Registry) where users store registry credentials. This PR adds a dropdown to select a stored registry when configuring a Docker image pull, avoiding redundant credential entry.Changes:
registryIdon the application and clears inline credentials when a registry is selected (and vice versa).buildRemoteDockerandgetAuthConfignow use the linked registry's credentials when available, falling back to inline credentials for backward compatibility.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
N/A
Screenshots (if applicable)