Conversation
Move building of the header filter filter expressions, `allowHeaderFiltering` and `invertFilterExpression` into `header_filter/utils.ts` and cover them with unit tests. The extender keeps its place in the chain and only delegates the expression building.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain.
Pull request overview
Extracts header-filter expression logic into reusable utilities while preserving behavior and adding test coverage.
Changes:
- Added typed header-filter expression helpers.
- Updated header-filter modules and test imports.
- Added unit and integration coverage.
File summaries
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/headerFilter.tests.js |
Updates the inversion utility import. |
packages/devextreme/js/__internal/grids/grid_core/header_filter/utils.ts |
Adds extracted header-filter expression helpers. |
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter.ts |
Uses the shared expression utilities. |
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter_core.ts |
Reuses shared filtering permission logic. |
packages/devextreme/js/__internal/grids/grid_core/header_filter/__tests__/header_filter.expressions.test.ts |
Tests utility behavior. |
packages/devextreme/js/__internal/grids/grid_core/data_controller/__tests__/data_controller.combined_filter.test.ts |
Adds combined-filter regression coverage. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.