Respect users-only directory sync target on OIDC login#2657
Open
danielheimburg wants to merge 1 commit intoDefGuard:mainfrom
Open
Respect users-only directory sync target on OIDC login#2657danielheimburg wants to merge 1 commit intoDefGuard:mainfrom
danielheimburg wants to merge 1 commit intoDefGuard:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directory_sync_target=usersduring external OIDC loginRoot cause
Periodic directory sync already respects the configured target and only syncs groups for
allorgroups.However, the external OIDC callback unconditionally called
sync_user_groups_if_configured, and that helper only checked whether directory sync was enabled, not which target was selected. As a result, logins through an external provider still rewrote group membership even when the provider was configured forusersonly.Code evidence
crates/defguard_core/src/enterprise/handlers/openid_login.rs: OIDC callback callssync_user_groups_if_configuredcrates/defguard_core/src/enterprise/directory_sync/mod.rs: periodicdo_directory_syncrespectsdirectory_sync_targetsync_user_groups_if_configureddo the sameTesting
sync_user_groups_if_configuredwithDirectorySyncTarget::Usersprotoctoolchain resolution during build, so the patch is code-reviewed but not fully executed here