Skip to content

[Fix-4514][metadata] Adding type to DriverPool's key - #4515

Closed
jrnie wants to merge 1 commit into
DataLinkDC:devfrom
jrnie:dev
Closed

[Fix-4514][metadata] Adding type to DriverPool's key#4515
jrnie wants to merge 1 commit into
DataLinkDC:devfrom
jrnie:dev

Conversation

@jrnie

@jrnie jrnie commented Dec 1, 2025

Copy link
Copy Markdown
  • Adding type to DriverPool's key

Purpose of the pull request

Fix-4514: [Bug] [metadata] DriverPool key needs to include a type to distinguish the JDBC connector types.

Brief change log

  • Add type to org.dinky.metadata.driver.Driver.java#build
  • Add type to org.dinky.controller.DataSourceController.java#saveOrUpdateDataBase

Verify this pull request

This pull request is code cleanup without any test coverage.

- Adding type to DriverPool's key
@aiwenmo

aiwenmo commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

The data source name is unique.

@jrnie

jrnie commented Dec 8, 2025

Copy link
Copy Markdown
Author
image image cdc任务首次进入时name并非独特的,比如图中的jdbc

The data source name is unique.

@aiwenmo

aiwenmo commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

It is possible to ensure uniqueness when constructing the "name", or objects with the same physical connection can be reused.

@aiwenmo

aiwenmo commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

#4523

@aiwenmo aiwenmo closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants