Skip to content

ffe: test that SDKs ignore unknown fields and condition operators#6820

Merged
dd-oleksii merged 2 commits intomainfrom
oleksii/jj-squtzkvzpvus
Apr 29, 2026
Merged

ffe: test that SDKs ignore unknown fields and condition operators#6820
dd-oleksii merged 2 commits intomainfrom
oleksii/jj-squtzkvzpvus

Conversation

@dd-oleksii
Copy link
Copy Markdown
Member

@dd-oleksii dd-oleksii commented Apr 27, 2026

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026 •
edited
Loading

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/ffe/test_dynamic_evaluation.py                                    @DataDog/feature-flagging-and-experimentation-sdk @DataDog/system-tests-core

@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Apr 27, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9b9a464 | Docs | Datadog PR Page | Give us feedback!

@dd-oleksii dd-oleksii force-pushed the oleksii/jj-squtzkvzpvus branch from 19d1018 to bf7a51f Compare April 27, 2026 21:33
typotter
typotter approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@typotter typotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

TIL: G.R.E.A.S.E.

thanks for making our code greasy

Comment thread manifests/dotnet.yml
tests/docker_ssi/test_docker_ssi_appsec.py::TestDockerSSIAppsecFeatures::test_telemetry_source_ssi: v3.36.0
tests/ffe/test_dynamic_evaluation.py: v3.36.0
tests/ffe/test_dynamic_evaluation.py::Test_FFE_Flag_Parse_Error_Isolation: bug (FFL-2184)
tests/ffe/test_dynamic_evaluation.py::Test_FFE_Unknown_Operator_Tolerance: bug (FFL-2184)
Copy link
Copy Markdown
Contributor

@typotter typotter Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFL-2182?

Copy link
Copy Markdown
Member Author

@dd-oleksii dd-oleksii Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFL-2182 is for making unknown operator an error. FFL-2184 is for isolating errors on flag level.

.NET SDK already fails to parse unknown operators, so that part (FFL-2182) is good. But it does not isolate errors to flags, so FFL-2184 is correct here.

@dd-oleksii dd-oleksii marked this pull request as ready for review April 28, 2026 13:57
@dd-oleksii dd-oleksii requested review from a team as code owners April 28, 2026 13:57
@dd-oleksii dd-oleksii requested review from amarziali, claponcet, daniel-romano-DD and leoromanovsky and removed request for a team April 28, 2026 13:57
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf7a51f145

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/ffe/test_dynamic_evaluation.py
sameerank
sameerank approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sameerank sameerank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No manifest updates for python and ruby means they already handle unknown fields & conditions correctly, right?

@dd-oleksii
Copy link
Copy Markdown
Member Author

dd-oleksii commented Apr 28, 2026

@sameerank yes!

@dd-oleksii dd-oleksii merged commit b13d5de into main Apr 29, 2026
449 checks passed
@dd-oleksii dd-oleksii deleted the oleksii/jj-squtzkvzpvus branch April 29, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@sameerank sameerank sameerank approved these changes

@typotter typotter typotter approved these changes

@claponcet claponcet Awaiting requested review from claponcet claponcet is a code owner automatically assigned from DataDog/asm-java

@daniel-romano-DD daniel-romano-DD Awaiting requested review from daniel-romano-DD daniel-romano-DD is a code owner automatically assigned from DataDog/asm-java

@amarziali amarziali Awaiting requested review from amarziali amarziali is a code owner automatically assigned from DataDog/apm-java

@leoromanovsky leoromanovsky Awaiting requested review from leoromanovsky leoromanovsky is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dd-oleksii @sameerank @typotter