Skip to content

[rust] generate a dev version and install prod version from crates.io#6764

Open
iunanua wants to merge 7 commits intomainfrom
igor/rust/prod
Open

[rust] generate a dev version and install prod version from crates.io#6764
iunanua wants to merge 7 commits intomainfrom
igor/rust/prod

Conversation

@iunanua
Copy link
Copy Markdown
Contributor

@iunanua iunanua commented Apr 16, 2026

Motivation

Enable prod tests for rust tracer

Changes

Modify install_ddtrace.sh‎ to:

  • dev: generate dinamically a version for the tracer based on: the next minor version, -dev sufix and +<githash> (for example 0.4.0-dev+961440933807d6354f7af5098e61e605ed137495) and use it when adding the dep via path
  • prod: add the latest published crate in crates.io

I have modified test_compute_libraries_and_scenarios.py‎ and compute_libraries_and_scenarios.py to enable prod and it seems it's working but it might be necessary to modify others.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

CODEOWNERS have been resolved as:

tests/test_the_test/test_compute_libraries_and_scenarios.py             @DataDog/system-tests-core
utils/build/docker/rust/install_ddtrace.sh                              @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/Cargo.lock                           @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/Cargo.toml                           @DataDog/apm-rust @DataDog/system-tests-core
utils/build/docker/rust/parametric/Dockerfile                           @DataDog/apm-rust @DataDog/system-tests-core
utils/scripts/compute_libraries_and_scenarios.py                        @DataDog/system-tests-core

@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented Apr 17, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Other Violations

🧪 3 Tests failed

tests.parametric.test_sampling_span_tags.Test_Knuth_Sample_Rate.test_sampling_knuth_sample_rate_trace_sampling_rule[below_precision_rounds_to_zero, parametric-java] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected _dd.p.ksr='0', got: 1e-07
assert '1e-07' == '0'
  - 0
  + 1e-07

self = <tests.parametric.test_sampling_span_tags.Test_Knuth_Sample_Rate object at 0x7efc259e21e0>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7efbf3bce030>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7efbf384f740>
expected_ksr = '0'

...
tests.parametric.test_sampling_span_tags.Test_Knuth_Sample_Rate.test_sampling_knuth_sample_rate_trace_sampling_rule[rounds_up_to_one_millionth, parametric-java] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected _dd.p.ksr='0.000001', got: 5.1e-07
assert '5.1e-07' == '0.000001'
  - 0.000001
  + 5.1e-07

self = <tests.parametric.test_sampling_span_tags.Test_Knuth_Sample_Rate object at 0x7efc259e2870>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7efbf3e214f0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7efbf3db6270>
expected_ksr = '0.000001'

...
tests.parametric.test_sampling_span_tags.Test_Knuth_Sample_Rate.test_sampling_knuth_sample_rate_trace_sampling_rule[six_decimal_precision_boundary, parametric-java] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected _dd.p.ksr='0.000001', got: 1e-06
assert '1e-06' == '0.000001'
  - 0.000001
  + 1e-06

self = <tests.parametric.test_sampling_span_tags.Test_Knuth_Sample_Rate object at 0x7efc259e1a00>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7efbf37294c0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7efbf3bcf200>
expected_ksr = '0.000001'

...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a7756fe | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@iunanua iunanua changed the title [rust]: generate a dev version and install prod version from crates.io [rust] generate a dev version and install prod version from crates.io Apr 17, 2026
@iunanua iunanua marked this pull request as ready for review April 17, 2026 10:02
@iunanua iunanua requested review from a team as code owners April 17, 2026 10:02
Copy link
Copy Markdown
Collaborator

@nccatoni nccatoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but bumping the minor means that if you work on a patch to the previous release it might not run all the tests

@iunanua
Copy link
Copy Markdown
Contributor Author

iunanua commented Apr 21, 2026

LGTM but bumping the minor means that if you work on a patch to the previous release it might not run all the tests

I can change it to bump a patch. wdyt @nccatoni?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants