Skip to content

Update debugger system tests for PHP#6760

Draft
bwoebi wants to merge 4 commits intomainfrom
bob/debugger-updates
Draft

Update debugger system tests for PHP#6760
bwoebi wants to merge 4 commits intomainfrom
bob/debugger-updates

Conversation

@bwoebi
Copy link
Copy Markdown
Contributor

@bwoebi bwoebi commented Apr 16, 2026

Fixed behaviours and new features added.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

CODEOWNERS have been resolved as:

tests/debugger/utils/approvals/php/1.18.0/exception_replay_async_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_async_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_async_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_async_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_inner_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_inner_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_inner_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_inner_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_multiframe_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_multiframe_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_multiframe_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_multiframe_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_20_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_20_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_20_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_20_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_3_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_3_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_3_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_3_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_4_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_4_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_4_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_4_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_5_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_5_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_5_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_recursion_5_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_rockpaperscissors_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_rockpaperscissors_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_rockpaperscissors_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_rockpaperscissors_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_simple_snapshots_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_simple_snapshots_received.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_simple_spans_expected.json  @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/approvals/php/1.18.0/exception_replay_simple_spans_received.json  @DataDog/debugger @DataDog/system-tests-core
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
tests/debugger/test_debugger_exception_replay.py                        @DataDog/debugger @DataDog/system-tests-core
tests/debugger/test_debugger_expression_language.py                     @DataDog/debugger @DataDog/system-tests-core
tests/debugger/test_debugger_inproduct_enablement.py                    @DataDog/debugger @DataDog/system-tests-core
tests/debugger/test_debugger_telemetry.py                               @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils.py                                                 @DataDog/debugger @DataDog/system-tests-core
utils/_context/_scenarios/debugger.py                                   @DataDog/system-tests-core
utils/build/docker/php/apache-mod/php.conf                              @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/apt-sources.d/ubuntu.sources                     @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/common/debugger.php                              @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/php-fpm/php-fpm.conf                             @DataDog/apm-php @DataDog/system-tests-core

@bwoebi bwoebi force-pushed the bob/debugger-updates branch 2 times, most recently from 2e430c7 to f884002 Compare April 16, 2026 14:22
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Apr 16, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 33 Tests failed

tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation.test_inproduct_enablement_di[apache-mod-7.0] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected probes to be emitting after enabling dynamic instrumentation
assert False
 +  where False = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation object at 0x7fe993977290>.di_explicit_enabled

self = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation object at 0x7fe993977290>

    def test_inproduct_enablement_di(self):
        self.assert_rc_state_not_error()
        self.assert_all_weblog_responses_ok()
    
...
tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation.test_inproduct_enablement_di[apache-mod-7.0] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected probes to be emitting after enabling dynamic instrumentation
assert False
 +  where False = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation object at 0x7fc72d9e7ef0>.di_explicit_enabled

self = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation object at 0x7fc72d9e7ef0>

    def test_inproduct_enablement_di(self):
        self.assert_rc_state_not_error()
        self.assert_all_weblog_responses_ok()
    
...
tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation.test_inproduct_enablement_di[apache-mod-7.0-zts] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected probes to be emitting after enabling dynamic instrumentation
assert False
 +  where False = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation object at 0x7fddcba82a50>.di_explicit_enabled

self = <tests.debugger.test_debugger_inproduct_enablement.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation object at 0x7fddcba82a50>

    def test_inproduct_enablement_di(self):
        self.assert_rc_state_not_error()
        self.assert_all_weblog_responses_ok()
    
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f09d4f8 | Docs | Datadog PR Page | Give us feedback!

@bwoebi bwoebi force-pushed the bob/debugger-updates branch 7 times, most recently from 9010299 to 67c9914 Compare April 23, 2026 11:10
@bwoebi bwoebi force-pushed the bob/debugger-updates branch from 67c9914 to 75bb7d2 Compare April 23, 2026 11:11
- Add DD_APPSEC_ENABLED=0 to DebuggerScenario to prevent appsec fields
  from appearing in exception replay snapshot comparisons
- Convert PHP line probes to method probes in set_probes() since PHP
  does not support line-level instrumentation
- Add PHP /debugger/init request in send_rc_apm_tracing_and_probes()
  to ensure RC is processed before the test request fires the probe
- double weblog debugger init to make sure
@bwoebi bwoebi force-pushed the bob/debugger-updates branch 3 times, most recently from cd1e96b to 9d960e9 Compare April 29, 2026 10:57
@bwoebi bwoebi force-pushed the bob/debugger-updates branch from 9d960e9 to f09d4f8 Compare April 30, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant