[observer] Add log status detector component#49119
Draft
CelianR wants to merge 2 commits intoq-branch-observerfrom
Draft
[observer] Add log status detector component#49119CelianR wants to merge 2 commits intoq-branch-observerfrom
CelianR wants to merge 2 commits intoq-branch-observerfrom
Conversation
CelianR
added
changelog/no-changelog
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 361 | 0 | 0 |
Updated: .gitlab/distribution.yml
Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 0 | 2 | 0 |
ℹ️ Diff available in the job log.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71328c81af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+108
to
+111
| Name: logStatMetricNames[status], | ||
| Value: 1.0, | ||
| Tags: log.GetTags(), | ||
| ContextKey: contextKey, |
There was a problem hiding this comment.
The emitted series key does not include the computed group (source/service/env/host): Name is only status-based and Tags are the original log tags. In the engine, storage and context refs are keyed by metric name + tags, so logs that differ only by GetHostname() (or any grouping dim not present in tags) collapse into one timeseries, and the last ContextKey wins. This breaks the intended per-group counting and can hide host-specific spikes when host is provided via LogView.GetHostname() but not as a host: tag.
Useful? React with 👍 / 👎.
Contributor
Go Package Import DifferencesBaseline: e5b320d
|
Contributor
Files inventory check summaryFile checks results against ancestor e5b320de: Results for datadog-agent_7.79.0~devel.git.426.71328c8.pipeline.106889080-1_amd64.deb:Detected file changes:
|
Contributor
Static quality checks❌ Please find below the results from static quality gates Error
Gate failure full details
Static quality gates prevent the PR to merge! Successful checksInfo
On-wire sizes (compressed)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new LogStatExtractor component that counts logs per canonical status (critical, error, warn, info, debug).
This counts logs per canonical status with grouping by source, service, env, and host
Motivation
Describe how you validated your changes
Additional Notes