feat: allow fileUpdater to handle multiple files #27#387
Closed
beingrahull wants to merge 1 commit intoDSACMS:mainfrom
Closed
feat: allow fileUpdater to handle multiple files #27#387beingrahull wants to merge 1 commit intoDSACMS:mainfrom
beingrahull wants to merge 1 commit intoDSACMS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions: Update fileUpdater to support multiple files
Problem
The current fileUpdater implementation only accepts a single file as input.
Users who need to update strings across multiple files (e.g., README.md and
CONTRIBUTING.md) have to run the workflow multiple times, which is
inefficient and creates unnecessary overhead. Fixes #27.
Solution
I modified the workflow and the underlying bash script to handle a
comma-separated list of files.
updateStringInRepos.ymlandaction.ymlto accept a list of files.update.shto use an IFS loop to split the input string.Result
The
fileinput now accepts multiple file paths separated by commas. Theaction will iterate through the list and apply the string replacement to
every valid file provided.
Test Plan
I verified the changes by running the
update.shscript locally with amock comma-separated string:
test1.txtandtest2.txt.bash .github/fileUpdater/update.sh "old" "new" "test1.txt,test2.txt".