fix: Hide top-level scrollbar on wrongly sized panels#794
Open
sfayer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We've found that there is a subtle bug in the webapp layouts on up-to-date Firefox when the page zoom level is set above 100% (specifically tested on 110%). Under these conditions the panel size calculations seem to go off-by-one (a rounding error somewhere?) and extra scrollbars appears at the bottom and side of the tab workspace. The problem is that these "outer" scrollbars cover up the real scrollbars on things like the Job Monitor, which prevents you from seeing all of the columns or scrolling up/down the list of jobs.
To fix this we've just set the TabPanel scrollable default to False to hide the extra scrollbars, this fixes the problem and doesn't have any adverse effects on any of the panels we usually use (it's possible that there is a panel somewhere relying on inheriting scrollable: true; we couldn't find any but they should probably set it explicitly if they need this behaviour).
Regards,
Simon
BEGINRELEASENOTES
FIX: Hide top-level scrollbar on wrongly sized panels
ENDRELEASENOTES