Add BarcodeScanner feedback guidance#895
Open
Vetle444 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds user-facing feedback improvements to the BarcodeScanner scan-rectangle flow, including inline validation messaging above the scan rectangle, haptic feedback for accepted/rejected scans, and an opt-in delayed zoom “hint” tip mechanism. Also updates the wiki, changelog, and Components sample app to document and demonstrate the new behavior.
Changes:
- Display short validation rejection messages above the scan rectangle during the failure animation.
- Add success/error haptics for accepted/rejected barcode results and introduce
BarcodeScannerStartOptions.Hint(BarcodeScannerHintOptions) for delayed zoom tips. - Add a new “Barcode scanner feedback” sample and update docs/changelog accordingly.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
wiki/Media/Camera.md |
Documents validation feedback messages and the new Hint options usage. |
src/library/DIPS.Mobile.UI/API/Camera/BarcodeScanning/Overlay/BarcodeScanRectangleOverlay.cs |
Implements the inline feedback message UI/animation above the scan rectangle. |
src/library/DIPS.Mobile.UI/API/Camera/BarcodeScanning/BarcodeScanSession.cs |
Adds success/error vibration feedback for accept/reject paths. |
src/library/DIPS.Mobile.UI/API/Camera/BarcodeScanning/BarcodeScannerStartOptions.cs |
Adds Hint property to configure automatic hint behavior. |
src/library/DIPS.Mobile.UI/API/Camera/BarcodeScanning/BarcodeScannerHintOptions.cs |
New options type for delayed zoom hint and related callbacks. |
src/library/DIPS.Mobile.UI/API/Camera/BarcodeScanning/BarcodeScanner.cs |
Schedules and manages the automatic hint timer lifecycle across scanner states. |
src/app/Components/Resources/LocalizedStrings/LocalizedStrings.resx |
Adds nb strings for the new feedback sample. |
src/app/Components/Resources/LocalizedStrings/LocalizedStrings.en.resx |
Adds en strings for the new feedback sample. |
src/app/Components/Resources/LocalizedStrings/LocalizedStrings.Designer.cs |
Updates generated accessors for new localized strings. |
src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeScanningHubSamples.xaml.cs |
Wires navigation to the new feedback sample. |
src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeScanningHubSamples.xaml |
Adds a hub list entry for the feedback sample using localized strings. |
src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeFeedbackSample.xaml.cs |
New sample demonstrating validation messaging, tooltip, and automatic zoom hint. |
src/app/Components/ComponentsSamples/BarcodeScanning/BarcodeFeedbackSample.xaml |
New sample page layout hosting CameraPreview. |
CHANGELOG.md |
Adds a public entry describing the new BarcodeScanner feedback behavior. |
Files not reviewed (1)
- src/app/Components/Resources/LocalizedStrings/LocalizedStrings.Designer.cs: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds BarcodeScanner feedback guidance for scan rectangle barcode scanning:
BarcodeScannerStartOptions.HintwithBarcodeScannerHintOptionsfor delayed camera zoom tips, includingCanShowHintAsyncandOnHintShownAsynchooks.Validation performed:
dotnet build src/app/Components/Components.csproj -f net10.0-ios -v minimal -clp:ErrorsOnlygit diff --cached --checkTodos