Skip to content

Remove unreachable code and fix typos in converter.cpp #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunoplopes merged 2 commits into from
Jun 4, 2026
Merged

Remove unreachable code and fix typos in converter.cpp #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88db9ad
Initial plan
Copilot Jun 4, 2026
00be3ba
Remove unreachable std::unreachable(), fix typos 'less that' and 'sup…
Copilot Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cpp2rust/converter/converter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2354,7 +2354,6 @@ bool Converter::ConvertIncAndDec(clang::UnaryOperator *expr) {
default:
return false;
}
std::unreachable();
}

bool Converter::VisitUnaryOperator(clang::UnaryOperator *expr) {
Expand Down Expand Up @@ -2814,7 +2813,7 @@ bool Converter::VisitInitListExpr(clang::InitListExpr *expr) {
if (auto arr_ty = ctx_.getAsConstantArrayType(expr->getType())) {
assert(
(arr_ty->getSize().getZExtValue() - expr->getNumInits()) &&
"Number of initializers should be less that total size of array");
"Number of initializers should be less than total size of array");
for (unsigned i = 0;
i < arr_ty->getSize().getZExtValue() - expr->getNumInits(); ++i) {
ConvertVarInit(expr->getArrayFiller()->getType(),
Expand Down Expand Up @@ -3002,7 +3001,7 @@ bool Converter::VisitCXXConstructExpr(clang::CXXConstructExpr *expr) {
if (ctor->isCopyOrMoveConstructor() ||
(ctor->isConvertingConstructor(false) && ctor->getNumParams() == 1 &&
ctor->getParamDecl(0)->getType()->isRValueReferenceType())) {
// Take supress before recursing into the child.
// Take suppress before recursing into the child.
bool suppress = PushSuppressIteratorClone::take(*this);
Convert(expr->getArg(0));
if (ctor->isCopyConstructor() && !suppress) {
Expand Down
Loading