[COR-2368] Fix inability to make a zero-knowledge proof in certain cases#667
Open
Ivan-Mahda wants to merge 6 commits intomainfrom
Open
[COR-2368] Fix inability to make a zero-knowledge proof in certain cases#667Ivan-Mahda wants to merge 6 commits intomainfrom
Ivan-Mahda wants to merge 6 commits intomainfrom
Conversation
Updated concordium base
Updated validation rules
soerenbf
reviewed
Apr 20, 2026
Contributor
There was a problem hiding this comment.
how come the concordium-base reference was updated as part of this? 🤔
Contributor
Author
There was a problem hiding this comment.
I looked at how it was done in other PRs
For example:
https://github.com/Concordium/concordium-node-sdk-js/pull/620/changes
And used command: git submodule update --remote --merge
The reason for this is that some of the changes for zkp were made in concordium-base, so it also needed to be updated.
Ivan-Mahda
requested a deployment
to
github-pages
GitHub Actions
Waiting
soerenbf
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix such that an attribute can both be used in bullet proofs and revealed at the same time. This was not possible for identity based presentations (actually, it depended on the order of the statements, if the prover would fail
Changes
Removed single statement checks and validation
Checklist
hard-to-understand areas.