Add Ideogram 4 Scheduler node with preconfigured presets.#14399
Add Ideogram 4 Scheduler node with preconfigured presets.#14399silveroxides wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used📓 Path-based instructions (3)**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
⚙️ CodeRabbit configuration file
Files:
comfy_extras/**⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (5)📚 Learning: 2026-02-21T14:01:41.482ZApplied to files:
📚 Learning: 2026-03-04T14:05:31.426ZApplied to files:
📚 Learning: 2026-04-04T13:29:15.653ZApplied to files:
📚 Learning: 2026-05-09T18:40:40.199ZApplied to files:
📚 Learning: 2026-05-20T00:10:14.673ZApplied to files:
🔇 Additional comments (2)
📝 WalkthroughWalkthroughThis PR adds an Ideogram 4 preset system: it imports 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
comfy_extras/nodes_ideogram4.py (1)
19-37: ⚡ Quick winUse enum-backed keys in
IDEOGRAM4_PRESET_CONFIGSto prevent preset drift.The preset identity is duplicated as free-form strings in both
Ideogram4EnumandIDEOGRAM4_PRESET_CONFIGS. A future rename/addition can desync dropdown options from config keys and fail at runtime inexecute. Key the config from enum values/constants directly.Suggested change
IDEOGRAM4_PRESET_CONFIGS = { - "Quality": { + Ideogram4Enum.QUALITY.value: { "num_steps": 48, "mu": 0.0, "std": 1.5, "preset_id": "V4_QUALITY_48" }, - "Default": { + Ideogram4Enum.DEFAULT.value: { "num_steps": 20, "mu": 0.0, "std": 1.75, "preset_id": "V4_DEFAULT_20" }, - "Turbo": { + Ideogram4Enum.TURBO.value: { "num_steps": 12, "mu": 0.5, "std": 1.75, "preset_id": "V4_TURBO_12" } }As per coding guidelines, community nodes should keep interfaces/patterns consistent to avoid breaking behavior drift.
Also applies to: 91-102
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@comfy_extras/nodes_ideogram4.py` around lines 19 - 37, The preset map IDEOGRAM4_PRESET_CONFIGS is keyed by free-form strings which duplicates identifiers in Ideogram4Enum and can drift; change the keys to use the enum-backed constants (use Ideogram4Enum.<NAME>.value or the enum member itself depending on enum definition) so the map keys come directly from Ideogram4Enum, update the other identical map at the other block (lines referenced around 91-102) the same way, and ensure anywhere the map is accessed (e.g., in execute) looks up by the enum value/member rather than a hard-coded string.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@comfy_extras/nodes_ideogram4.py`:
- Around line 19-37: The preset map IDEOGRAM4_PRESET_CONFIGS is keyed by
free-form strings which duplicates identifiers in Ideogram4Enum and can drift;
change the keys to use the enum-backed constants (use Ideogram4Enum.<NAME>.value
or the enum member itself depending on enum definition) so the map keys come
directly from Ideogram4Enum, update the other identical map at the other block
(lines referenced around 91-102) the same way, and ensure anywhere the map is
accessed (e.g., in execute) looks up by the enum value/member rather than a
hard-coded string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 367494fa-85ac-4673-8d62-a9bb6047e6d9
📒 Files selected for processing (1)
comfy_extras/nodes_ideogram4.py
…houroughly tested to give good results relative to step count and resolution.
Would reduce UI bloat significantly in both template and for easy and quick deployment.
EDIT: I also added two additional presets that close the cap between default and quality presets and provide a middleground between turbo and default on the lower end.