Add: include enumeration class CaloricGasModel to simplify caloric gas model definition#1089
Merged
AlbertoCuadra merged 1 commit intomasterfrom Oct 19, 2025
Merged
Add: include enumeration class CaloricGasModel to simplify caloric gas model definition#1089AlbertoCuadra merged 1 commit intomasterfrom
CaloricGasModel to simplify caloric gas model definition#1089AlbertoCuadra merged 1 commit intomasterfrom
Conversation
…nition of the caloric gas model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
CaloricGasModelenumeration to define the caloric gas model explicitly (perfect,thermallyPerfect,imperfect). This replaces the previous dual-flag mechanism (FLAG_TCHEM_FROZEN,FLAG_FROZEN) and avoids invalid combinations that could occur silently.Backward Compatibility
Example