Snapshot tests for the flutter code#60
Merged
gabrielbmoro merged 9 commits intomainfrom Aug 14, 2025
Merged
Conversation
gabrielbmoro
commented
Aug 7, 2025
| textColorHex: '#800080', | ||
| backgroundHex: '#000000', | ||
| textSize: '24.0', | ||
| textAllCaps: true, |
Collaborator
Author
There was a problem hiding this comment.
It is really weird, it looks like all caps is not working
gabrielbmoro
commented
Aug 7, 2025
| flutter: | ||
| fonts: | ||
| - family: Roboto | ||
| fonts: |
Collaborator
Author
There was a problem hiding this comment.
By default, flutter needs a font to the test env
gabrielbmoro
commented
Aug 7, 2025
|
|
||
| jobs: | ||
| build: | ||
| runs-on: macos-latest # Use macOS because I generated the golden images in my macoOS |
Collaborator
Author
There was a problem hiding this comment.
I need to run this on macos, considering I generated the golden images on my macos laptop
Contributor
This commit introduces two new properties to the `CraftDButton` widget: - `fillMaxSize`: When set to `true`, the button will expand to fill the available width. - `textAllCaps`: When set to `true`, the button's text will be displayed in uppercase. Corresponding snapshot tests have been added to verify these new functionalities. The `CraftDText` widget was also updated to respect the `textAllCaps` property.
…Tests
This commit introduces snapshot tests for the `CraftDText` widget and refactors existing snapshot tests for the `CraftDButton` widget.
**CraftDText Snapshot Tests:**
- Added two new snapshot tests for `CraftDText`:
- `craftd_text_allcaps_false_snapshot.png`: Verifies the rendering of `CraftDText` with `textAllCaps` set to `false`.
- `craftd_text_allcaps_true_snapshot.png`: Verifies the rendering of `CraftDText` with `textAllCaps` set to `true`.
**CraftDButton Snapshot Tests Refactoring:**
- Renamed and updated existing `CraftDButton` snapshot tests to improve clarity and reflect the tested property:
- `craftd_button_allcaps_snapshot.png` was removed and its test case modified to test `fillMaxSize: false`, resulting in `craftd_button_fill_max_size_false_snapshot.png`.
- `craftd_button_fill_max_size_snapshot.png` was renamed to `craftd_button_fill_max_size_true_snapshot.png` to explicitly indicate that `fillMaxSize` is `true`.
- Adjusted the properties (text color, background color, `textAllCaps`, `fillMaxSize`) in the `CraftDButton` test cases to align with the new snapshot test names and the properties being tested.
The `CraftDText` widget was not applying the background color specified in `textProperties`. This commit fixes the issue by setting the `backgroundColor` in the `TextStyle`.
Additionally, this commit:
- Adds default values for text properties in snapshot tests to improve readability and maintainability.
- Introduces new snapshot tests for `CraftDText` to cover different scenarios:
- Text with orange text color
- Text with orange background color
- Text with a big font size
- Updates existing snapshot images to reflect the changes.
Adds a golden file test for the `CraftDEmpty` widget to ensure its visual representation remains consistent.
gabrielbmoro
changed the title
gabrielbmoro
commented
Aug 7, 2025
| @override | ||
| Widget build(BuildContext context) { | ||
| if (buttonProperties.fillMaxSize == true) { | ||
| return SizedBox( |
Collaborator
Author
There was a problem hiding this comment.
Bug fix: fillMaxSize was not working properly
gabrielbmoro
commented
Aug 7, 2025
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final String text = textProperties.textAllCaps == true |
Collaborator
Author
There was a problem hiding this comment.
Bug fix: textAllCaps was not working properly
gabrielbmoro
commented
Aug 7, 2025
| ? double.tryParse(textProperties.textSize!) | ||
| : 16.0, | ||
| color: CraftDColor.hexToColor(textProperties.textColorHex), | ||
| backgroundColor: CraftDColor.hexToColor(textProperties.backgroundHex), |
Collaborator
Author
There was a problem hiding this comment.
Bug fix: backgroundColor was not working properly
The `flutter test` command was removed from the Flutter snapshot tests workflow. This is because the tests are already being run by the integration tests.
gabrielbmoro
commented
Aug 8, 2025
| branches: | ||
| - main | ||
| paths: | ||
| - "flutter/**" |
Collaborator
Author
There was a problem hiding this comment.
any changes in the flutter source set will trigger this workflow
gabrielbmoro
commented
Aug 8, 2025
| branches: | ||
| - main | ||
| paths: | ||
| - "flutter/craftd_widget/lib/presentation/ui/**" |
Collaborator
Author
There was a problem hiding this comment.
any changes in the ui folder (inside of flutter package) will trigger this workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update enhances our snapshot testing infrastructure and test cases for CraftD Flutter components.
Bug fixes:
It closes:
Check list